Wsdl schema mapping improvements #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksanderis
force-pushed
the
wsdl-schema-mapping-improvements
branch
from
f1733fb
to
4d6e2d5
Compare
|
Force-pushed same commits, but with removed line-breaks changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some improvements for external WSDL schemas support:
WsdlFileOptionsCaseInsensitiveoptions - to use with case-insensitive mapping. Without it, even if you useSoapCoreOptions.CaseInsensitivePath = true- external WSDL schemas would fail to map byHttpContext.Request.Path.UrlOverrideproperty toWebServiceWSDLMapping. It's needed to be able to host services under different folders. For example if you have one service hosted like - https://localhost:5001/Management/Service.asmx, and another one - as https://localhost:5001/Orders/Customers.asmx. I didn't manage to achieve this goal with existingUrlOverride,VirtualPath,AppPathproperties inWsdlFileOptions.Short afterword: I hope the goals I was trying to achieve are clear. As about implementation - I'm ready to do additional changes in case someone has any better ideas or if there are some general issues or inconsistencies with the nature of SoapCore.
For now I tried to be cautious and add functionality on top. If it would be mine own project - then, for example I perhaps
WsdlFileOptionsCaseInsensitivecould just replaceWsdlFileOptions, because it's just would be more flexible. However I didn't want to introduce any potential breaking changes.