XmlNode/XmlElement as an Input Parameter #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the issue details from DigDes#908, implemented an XmlDocument parse of the input parameter.
New Test Cases to check for XmlElement return type in both integration testing and as an XML SOAP message. Also, added an XmlElement input parameter to allow the code to accept a free-form Xml Document/Element
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "; | ||
| using (var host = CreateTestHost()) | ||
| using (var client = host.CreateClient()) | ||
| using (var content = new StringContent(body, Encoding.UTF8, "text/xml")) |
Check warning
Code scanning / CodeQL
Information exposure through transmitted data Medium
The test was failing due to Windows vs Linux New Line sequence. Updated the sequence
|
Apologies for the failing test case - it was a matter of Windows vs Linux in running the test when replacing new line characters. Updated to use Environment.NewLine instead. |
|
Looks good. Is there anything else you would like to add before merging? I think it's acceptable if it doesn't work with an XmlNode return type, since it's not a regression. |
|
At the moment, I’m ok. I was able to successfully test in my own development project with the changes so that worked better. Thank you for the descriptions you added in the issue to help us.
Raymond Mimick
From: Anders Mörner ***@***.***>
Sent: Wednesday, August 16, 2023 3:39 AM
To: DigDes/SoapCore ***@***.***>
Cc: Raymond Mimick ***@***.***>; Author ***@***.***>
Subject: Re: [DigDes/SoapCore] XmlNode/XmlElement as an Input Parameter (PR #955)
Looks good. Is there anything else you would like to add before merging? I think it's acceptable if it doesn't work with an XmlNode return type, since it's not a regression.
—
Reply to this email directly, view it on GitHub <#955 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4ONTYEP64VOTQKIUGU5CTXVSBIXANCNFSM6AAAAAA3EXSJZ4> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AA4ONTZQ3AF24DPFVC5LC3LXVSBIXA5CNFSM6AAAAAA3EXSJZ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEEXDEI.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently experienced the Null value described in the issue #908 and decided to see if I could follow the suggested changes. In this pull request, I have added the suggested fix from @andersjonsson and then I also added a few Unit Tests for it.
In the integration tests, we have an XmlElement return type only and then a second test with both an XmlElement input and an XmlElement return time.
I have also added a new folder called XmlNodeInputOutputTests for the purpose of testing the XmlElement functions as a SOAP function vs a ChannelFactory object. I found the code is not quite happy with an XmlNode return type (the Test Server returns a message stating that it didn't get enough to consider a valid response).
Thank you,
Raymond Mimick