chore: improve eslint #3835
Merged
chore: improve eslint #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septs
force-pushed
the
septs/improve-eslint
branch
2 times, most recently
from
6cd4ff9
to
c0e9bf1
Compare
guanbinrui
previously approved these changes
Aug 2, 2021
Jack-Works
requested changes
Aug 2, 2021
Jack-Works
reviewed
Aug 2, 2021
chore: improve eslint
septs
force-pushed
the
septs/improve-eslint
branch
from
98cf502
to
4c1682d
Compare
guanbinrui
reviewed
Aug 3, 2021
guanbinrui
reviewed
Aug 3, 2021
guanbinrui
reviewed
Aug 3, 2021
packages/maskbook/src/social-network-adaptor/facebook.com/automation/pasteTextToComposition.ts
Outdated
Show resolved
Hide resolved
guanbinrui
previously approved these changes
Aug 3, 2021
guanbinrui
previously approved these changes
Aug 3, 2021
zhouhanseng
previously approved these changes
Aug 3, 2021
himself65
previously approved these changes
Aug 3, 2021
Jack-Works
reviewed
Aug 3, 2021
Jack-Works
reviewed
Aug 3, 2021
packages/maskbook/src/extension/background-script/EthereumServices/nonce.ts
Outdated
Show resolved
Hide resolved
Jack-Works
reviewed
Aug 3, 2021
packages/maskbook/src/extension/background-script/EthereumServices/send.ts
Outdated
Show resolved
Hide resolved
Jack-Works
reviewed
Aug 3, 2021
packages/maskbook/src/extension/background-script/StorageService.ts
Outdated
Show resolved
Hide resolved
Jack-Works
reviewed
Aug 3, 2021
Jack-Works
reviewed
Aug 3, 2021
septs
dismissed stale reviews from himself65, zhouhanseng, and guanbinrui
via
6d80619
Jack-Works
approved these changes
Aug 3, 2021
guanbinrui
approved these changes
Aug 3, 2021
yanzhihong23
added a commit
that referenced
this pull request
Aug 4, 2021
* develop: (93 commits) chore: add no-var rule (#3846) feat: the Risk Warning Dialog (#3833) fix(twitter): tweet selector fails to get link-only tweet content (#3837) chore: cleanup try-catch (#3840) chore: simplify urlcat builder (#3843) fix: parseint radix unset (#3844) chore: improve eslint (#3835) feat: introduce arbitrum network (#3558) fix: show nan in dashboard asset list (#3828) chore: simplify typing (#3825) refactor: revamp redpacket (#3809) feat: enable new dashboard in beat (#3826) fix: eslint (#3823) Update flags.ts (#3824) refactor: add v2_enabled flag (#3820) RFC: new payload v-37 and TypedMessage binary format (#2623) fix: bridge is down (#3821) feat: set experimentalMark on 3 plugins (#3669) fix: snapshot break down (#3814) refactor: compile contracts cli (#3798) ...
guanbinrui
pushed a commit
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #