Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market: Cancel all button rework #424

Closed
FrutyX opened this issue Sep 29, 2022 · 4 comments
Closed

Market: Cancel all button rework #424

FrutyX opened this issue Sep 29, 2022 · 4 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Sep 29, 2022

When cancelling too many items (10 - 15+), it creates too many server requests in a short time and this returns an 503 server error.

market

Without scrapping the feature, a possible solution would be to alter the script, to send those requests with a time delay between each request.

@GreatApo
Copy link
Member

We may need to do something about this, a notification or retry the requests.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jun 6, 2024

Apo, since you been around now, what would you do about this? It's one of those issues, that would be nice to deal with, if we ever release another update.

I have tried it just today, and once you cancel too many items, it just throws 503 at you, first at the console, but you can even get a 503 blank page.

We either need to slow it down, retry or limit the number that can be canceled. But I don't want you to waste too much time on this, it needs a simple change, without reworking the whole code.

FrutyX added a commit that referenced this issue Jun 7, 2024
@FrutyX FrutyX changed the title Market: Cancel all button - delay server requests Market: Cancel all button rework Jun 7, 2024
@GreatApo
Copy link
Member

GreatApo commented Jun 8, 2024

I slightly modified @FrutyX 's code and just added a delay between requests. It seems to work fine (tested with 16 items).

GramThanos added a commit that referenced this issue Sep 14, 2024
fixed cancel wrong item id
fixed no wait time between requests
added more wait time based on server response time to avoid spamming the server on high load/traffic periods
@GramThanos
Copy link
Member

  • fixed cancel wrong item id
  • fixed no wait time between requests
  • added more wait time based on server response time to avoid spamming the server on high load/traffic periods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants