Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-platform image push #49

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Fix multi-platform image push #49

merged 1 commit into from
Sep 17, 2023

Conversation

frodeaa
Copy link
Contributor

@frodeaa frodeaa commented Sep 17, 2023 •
edited
Loading

The image built by buildx is not by default loaded into docker images
list so the push failed

docker push docker.io//:latest
An image does not exist locally with the tag: /
The push refers to repository [docker.io//]
make: *** [Makefile:23: publish] Error 1

Update the publish target to just push the image from buildx build

Blame: #48

@frodeaa
Fix multi-platform publish
35045f0 
The image built by buildx is not by default loaded into `docker images`
list so the push failed

> docker push docker.io/***/***:latest
> An image does not exist locally with the tag: ***/***
> The push refers to repository [docker.io/***/***]
> make: *** [Makefile:23: publish] Error 1

Update the publish target to just push the image from buildx build

Blame: #48

    Use docker buildx to build multi-platform images (#48)

    Extends the build steps to include `docker/setup-buildx-action@v3` as
    GitHub actions does by default not support multiple platforms and build
    the image with platform linux/amd64 and linux/arm64
@frodeaa frodeaa self-assigned this Sep 17, 2023
@frodeaa frodeaa added the bug Something isn't working label Sep 17, 2023
@frodeaa frodeaa changed the title Fix multi-platform publish Fix multi-platform image push Sep 17, 2023
@frodeaa frodeaa merged commit e71f02c into master Sep 17, 2023
1 check passed
@frodeaa frodeaa deleted the fix-multi-platform branch September 17, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frodeaa frodeaa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frodeaa