feat: canoncialize assets for macOS, Windows, and Linux #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables assets to be served locally through cargo run or through a bundle strategy. We use cargo-bundle's bundle strategy. This PR checks only for macOS targets.
4 tasks
|
We will add windows/linux later, or anyone apsiring to figure it out can take care of it. It seems that when building with cargo-wix, you can choose the resource directory. Same with linux. Either we'll work with the tauri config and get theirs working by default or come up with our owm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the right relative pathing for assets when bundled through cargo-bundle.
It's never been this easy to include an image in your Rust
.app! :)I don't have any other machine than a mac box so I can't test alternate implementations.
https://crates.io/crates/directories
These targets do not provide a straightforward way of bundling assets. I've opted to make it the asset dir configurable instead.