-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Runtime #2973
Closed
Closed
Refactor the Runtime #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthunz
added
core
relating to the core implementation of the virtualdom
tweak
Small changes to improve experience
labels
Sep 17, 2024
matthunz
changed the title
Replace thread-local runtime stack with
Refactor the Runtime
Sep 17, 2024
Option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime
once per frontend application.RuntimeState
and redefinesRuntime
as a wrapper around it. This lets us simplify the external API without requiring users know how theRuntime
is stored (similar to Tokio).Runtime
seems to use a thread-local stack of runtimes with aVec
. This replaces the stack with a singleOption
and adds a newRuntime::take
method (to exit the current runtime and return it to the user, keeping that same behavior of a stack if desired)