Fix Internal Links with Base Path and Enable External Links Without Modifier #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeWimbes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following issues:
base_pathis set inDioxus.toml, internal links only worked with a simple left click; CTRL + left click failed because thehrefonly contained the absolute path to the next page without thebase_url.actionoverwriting the normal left click behavior. This issue is independent of thebase_path.Additionally, I noticed that this commit broke base paths in general, but this pull request does not address that issue.
This is one of my first pull requests, so please let me know if there are any changes or improvements needed. Thank you!