Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional show hidden LayoutAnchorable on hover #267

Merged
merged 3 commits into from
May 1, 2021

Conversation

corytodd
Copy link
Contributor

For our use case we would like the option to not auto-show a LayoutAnchorable
on mouse over (via mouse enter). This adds a new property to provide an option
to disable the auto-show behavior. Serialization support included.

Is there a better way to handle this?

For our use case, it is nice if we have the option to not unhide an
anchorable when the mouse enters the docked tab. This adds an optional
property to control this behavior. The default is to show on hover
just like always. Serialization support is included.
@Dirkster99
Copy link
Owner

Hi Cory, your suggestion looks good to me but can we please make the following adjustments:

  1. set the default value of the CanShowOnHover="False" (so others are not put off by this new default behavior)
  2. could you please decorate some items like the new property with a meaningful comment so we still know what this is doing when we look at it in a few months?

Otherwise, I think this is good to go, thanx for your contribution :-)

Document changes relating to this new behavior
@corytodd
Copy link
Contributor Author

Thanks for the fast response!

  1. I think we are respecting the default behavior by setting the backing field to true? I agree that we would want to maintain the current behavior by default which this does. Let me know if I'm misunderstanding what you're asking.
  2. Will do, wasn't sure if you prefer PRs to "blend in" with the existing code or you like comments. Going with the latter :)

@Dirkster99
Copy link
Owner

Sorry about 1. - I made a mistake here :-) so you are perfectly right and I was perfectly wrong, thanx for you patience

@Dirkster99 Dirkster99 merged commit 47ce0f9 into Dirkster99:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants