Skip to content

Latest commit

 

History

History
59 lines (39 loc) · 2.66 KB

SIP-0064.md

File metadata and controls

59 lines (39 loc) · 2.66 KB
Raw
SIP Title Author Status Track Created
0064
Remove Bridge Functions from Mynt
Tyrone Johnson (@tjcloa)
Defeated (no quorum)
Contract
2023-06-07

SIP-0064: Remove Bridge Functions from Mynt

Description

There are two Mynt contract updates included in this SIP:

  • Removal of legacy code related to the Sovryn Bridge integration
  • Technical update of the contracts with the bytecode changed due to modified NatSpec comments

1) Removal of legacy bridges related code

Mynt was initially cloned from Babelfish protocol as the basis for Sovryn DLLR BTC-based stablecoin.

Babelfish uses bridges as trusted sources for conversions. However it was decided not to use the bridges in Mynt.

To keep Mynt development on schedule, the bridge-related functionality was muted and unused, which created technical debt that we are paying back now with this SIP.

Unused code in smart contracts not only causes confusion for reviewers and integrators but is also a potential source of bugs and vulnerabilities in the future.

Following smart contract security best practices we have removed all the code related to bridge integration.

2) Technical upgrade

Changes in OpenZeppelin (OZ) contract Initializable inherited by FeesVault and MocIntegration contracts: OZ package version upgrade to 4.8.3 among other fixes changed the NatSpec function comments, which are added by a solidity compiler as metadata to the bytecode of the FeesVault and MocIntegration contracts:

   FeesVault Contract NatSpec Comment Change

If approved, this proposal will update the following Mynt contracts affected by the code cleanup: BasketManagerV3, MassetManager, FeesManager, FeesVault, and MocIntegration.

Proposed change

Existing logic contracts
BasketManagerV3: 0xb61Ff601E0b4531e39d9683c5Ab48873ccFd352B
MassetManager: 0x90F16042abF49e3c08d7D37Aa5b8eDc439DF1D9d
FeesManager: 0x1Cc0278c59577641E9fE38a0F698D15dA6CA47e4
FeesVault: 0x0e87Fd4cF5C7e78ab0B1Cc2dEc31C2D34355D9f0
MocIntegration: 0x68D06009d4DD7c189B9f5dF1D53aCffC5bF898aF

New logic contracts
BasketManagerV3: 0x4Ec09f11E667dd39E8751A07a74a2F90712Ef322
MassetManager: 0x15e34a753854be868b6c99333964ae655c2bab4f
FeesManager: 0xccCa715033DC18240bd30D4A99d084D3329e9B73
FeesVault: 0x5ad2ef1259a1b65558f56738f73998597ef300e5
MocIntegration: 0xb9d63f4ab03e92760d014c300c18b37783a5ac7e

Proposed changes: Mynt PR#13

License

Copyright and related rights waived via CC0.