Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOV-1370: Remove Bridge Related Code #13

Merged
merged 38 commits into from
Dec 21, 2023
Merged

SOV-1370: Remove Bridge Related Code #13

merged 38 commits into from
Dec 21, 2023

Conversation

tjcloa
Copy link
Contributor

@tjcloa tjcloa commented Jun 6, 2023 •
edited
Loading

  • Removes legacy bridge related code
  • Improves events of MocIntegrationContract for better information representation

@tjcloa tjcloa self-assigned this Jun 6, 2023
cwsnt
cwsnt reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@cwsnt cwsnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But, do you manage to run the yarn command successfully?
I got an error when running it although hh compile is working fine.

@jjmr007 jjmr007 force-pushed the SOV-1370-remove-bridge-functions branch from 39b70bb to 52afa9e Compare June 15, 2023 14:31
@tjcloa tjcloa force-pushed the SOV-1370-remove-bridge-functions branch from 39d500a to 5c7f936 Compare August 10, 2023 11:01
@tjcloa tjcloa merged commit 7d72943 into development Dec 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsnt cwsnt cwsnt approved these changes

@ororopickpocket ororopickpocket ororopickpocket approved these changes

Assignees

@tjcloa tjcloa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjcloa @cwsnt @ororopickpocket