Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable set vesting stakes if lockedDate lesser than blockTimestamp #492

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

cwsnt
Copy link
Contributor

@cwsnt cwsnt commented Mar 8, 2023

No description provided.

@cwsnt cwsnt self-assigned this Mar 8, 2023
@cwsnt cwsnt requested a review from tjcloa March 9, 2023 08:43
Copy link
Contributor

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the deprecation warning comment (see inline comments) and a typo

staking.stake(values[2], lockedDates[2], a1, a1, { from: guy }),
]);

await time.increase(2592000); // incerease timestamp 30 days, so that lockedDates will be < blockTimestamp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo incerease -> increase

lockedTS - block.timestamp <= MAX_DURATION,
"Invalid lock dates: exceed max duration"
);
if (lockedTS > block.timestamp) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function is said to be deprecated. consider removing the deprecation comment if the deprecation intention is outdated.

@cwsnt cwsnt merged commit 5188c4d into development Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants