prevent transferWithPermit griefing attack

DistributedCollective · Nov 15, 2023 · bff2d4e · bff2d4e
1 parent 331471b
commit bff2d4e
Show file tree

Hide file tree

Showing 18 changed files with 1,113 additions and 27 deletions.
diff --git a/contracts/meta-asset-token/MetaAssetToken.sol b/contracts/meta-asset-token/MetaAssetToken.sol
@@ -185,7 +185,10 @@ contract MetaAssetToken is ERC20Permit, Ownable {
         bytes32 _r,
         bytes32 _s
     ) external requireValidRecipient(_to) {
-        permit(_from, msg.sender, _amount, _deadline, _v, _r, _s);
+        if (allowance(_from, msg.sender) < _amount) {
+            permit(_from, msg.sender, _amount, _deadline, _v, _r, _s);
+        }
+
         require(
             transferFrom(_from, _to, _amount),
             "MetaAssetToken::transferWithPermit: transfer failed"

diff --git a/dist/deployment/deploy/102_TransferOwnership.js b/dist/deployment/deploy/102_TransferOwnership.js
diff --git a/dist/deployment/deploy/102_TransferOwnership.js.map b/dist/deployment/deploy/102_TransferOwnership.js.map
diff --git a/dist/deployment/helpers/deployment.js b/dist/deployment/helpers/deployment.js
diff --git a/dist/deployment/helpers/deployment.js.map b/dist/deployment/helpers/deployment.js.map
diff --git a/dist/hardhat.config.js b/dist/hardhat.config.js