Minimal security warning in deploy chapter. cf #802 #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this is exactly the perfect place for the warning, or the perfet wording, or the perfect place to point people towards, but I thought maybe it was a good start? once we merge/fix this, i think it's ok to close #802 in favour of DjangoGirls/tutorial-extensions#101 |
|
Thank youuu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending writing our own tutorial-extension re security (DjangoGirls/tutorial-extensions#101), and ref #802, this at least warns the user about not-ideal security settings, and points them towards the official Django deployment checklist (which discusses SECRET_KEY, DEBUG, etc)