Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to actions/deploy-pages #1791

Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Apr 6, 2023

This uses the currently beta feature of using GitHub Actions to deploy GitHub Pages, rather than using a gh-pages branch. This keeps the repository size smaller.

While this feature is beta, it is used by default.

This does require a change on the repo itself and since I don't have the permissions, someone else will need to do this. https://github.blog/changelog/2022-07-27-github-pages-custom-github-actions-workflows-beta/ shows how to.

This will make it easier to publish large artifacts, such as ebooks (see #1785).

This uses the currently beta feature of using GitHub Actions to deploy
GitHub Pages, rather than using a gh-pages branch. This keeps the
repository size smaller.
@ekohl ekohl requested a review from a team as a code owner April 6, 2023 10:45
Copy link
Contributor

@amakarudze amakarudze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekohl!

@das-g
Copy link
Member

das-g commented Apr 19, 2023

I've now changed the "Source" setting at https://github.com/DjangoGirls/tutorial/settings/pages to "GitHub Actions". Are any other changes to settings needed?

@ekohl
Copy link
Collaborator Author

ekohl commented Apr 19, 2023

@das-g no, that should be sufficient. Want to try and merge it to see how it performs?

@amakarudze amakarudze merged commit 39b7faa into DjangoGirls:master Apr 19, 2023
@ekohl ekohl deleted the remove-need-for-gh-pages-branch branch April 19, 2023 10:50
@ekohl
Copy link
Collaborator Author

ekohl commented Apr 19, 2023

I think that looks good. Shall we delete the gh-pages branch now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants