[WIP] Add Glint types #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snewcomer do you happen to know if this addon is still being maintained? I'd like to build on this PR but there hasn't been much activity in this repo lately |
|
@charlesfries did you manage to get anywhere with the types? there is a (maintained) fork of this addon at https://github.com/NullVoxPopuli/ember-composable-helpers, you probably could get them merged there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Glint types.
The types are guaranteed to be wrong at places, but get the ball rolling and should provide at least some value.
Not sure I will have much time to finish these, so perhaps others could take it from here.