Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade @rollup/plugin-replace #164

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Downgrade @rollup/plugin-replace #164

merged 1 commit into from
Feb 14, 2020

Conversation

eshtadc
Copy link
Contributor

@eshtadc eshtadc commented Feb 14, 2020

Fixes #163

@eshtadc eshtadc requested a review from jleja February 14, 2020 18:35
jleja
jleja approved these changes Feb 14, 2020
View reviewed changes
Copy link

@jleja jleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified pinning the rollup plugin works in a new project. 👏

Screen Shot 2020-02-14 at 1 40 40 PM

@eshtadc eshtadc merged commit fbe09cc into master Feb 14, 2020
@eshtadc eshtadc deleted the replace-error branch February 14, 2020 18:44
@eshtadc eshtadc mentioned this pull request Feb 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleja jleja jleja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Worker registration failed with TypeError: Failed to register a ServiceWorker
2 participants
@eshtadc @jleja