fix: Disable cross-frame focus lock (#840)

Doist · Aug 30, 2024 · e2e97b4 · e2e97b4
1 parent e194265
commit e2e97b4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
 
+# v25.1.1
+
+-   [Fix] Restrict focus locking in the `Modal` component to its containing document/iframe.
+
 # v25.1.0
 
 -   [Feat] Add `xsmall` size to the `Modal` component

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
         "email": "[email protected]",
         "url": "http://doist.com"
     },
-    "version": "25.1.0",
+    "version": "25.1.1",
     "license": "MIT",
     "homepage": "https://github.com/Doist/reactist#readme",
     "repository": {

diff --git a/src/modal/modal.tsx b/src/modal/modal.tsx
@@ -247,7 +247,12 @@ export function Modal({
                 onPointerDown={hideOnInteractOutside ? handleBackdropClick : undefined}
                 ref={backdropRef}
             >
-                <FocusLock autoFocus={autoFocus} whiteList={isNotInternalFrame} returnFocus={true}>
+                <FocusLock
+                    autoFocus={autoFocus}
+                    whiteList={isNotInternalFrame}
+                    returnFocus={true}
+                    crossFrame={false}
+                >
                     <Dialog
                         {...props}
                         ref={dialogRef}