chore: Fix links to Reactist components in storybook stories #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, it seems like my fix doesn't actually do anything when testing in Reactist Storybook https://doist.github.io/reactist/?path=/docs/components-input--input-story I was apparently meant to concat 
although I'm not sure it will actually do what I want it to do, consistently. Either way, I will investigate and follow-up on this in #795 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
While browsing a couple of Reactist storybook stories, I've noticed that there are some broken links that don't include the path "reactist":
CleanShot.2023-07-31.at.15.17.17.mp4
This PR should fix those links so that do include the correct path and therefore lead the viewer to the right place. (I cannot actually test what will actually happen when this gets deployed to https://doist.github.io/reactist/, as the storybook dev version deployed via Chromatic (linked in the builds below) does not actually include the custom "/reactist/" path in the URL 🤷♀️ Either way, this won't break things more than they are now.
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
Bumped patch. This is just a doc change.