Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: render-based composition #829

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Jul 1, 2024

🔗 References

https://ariakit.org/guide/composition#changing-the-html-element

🗺️ Overview

Please describe your implementation and any details that we should keep in mind during review.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

@gnapse gnapse self-assigned this Jul 1, 2024
@gnapse gnapse changed the base branch from main to next July 1, 2024 20:40
@gnapse gnapse changed the title Ernesto/render based composition BREAKING: render-based composition Jul 1, 2024
@gnapse gnapse force-pushed the ernesto/render-based-composition branch from c2dc494 to 97208a0 Compare July 2, 2024 14:16
@gnapse gnapse marked this pull request as ready for review July 2, 2024 14:23
@gnapse gnapse force-pushed the ernesto/render-based-composition branch 2 times, most recently from f461914 to 6c03b45 Compare July 5, 2024 14:05
@gnapse gnapse force-pushed the ernesto/render-based-composition branch from 6c03b45 to 0d7d74b Compare July 5, 2024 19:57
@gnapse gnapse merged commit 45c6a65 into next Jul 8, 2024
3 of 5 checks passed
@gnapse gnapse deleted the ernesto/render-based-composition branch July 8, 2024 20:15
@gnapse gnapse mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant