-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update form field components to align with the new design spec #842
Conversation
5454c66
to
5aa7a30
Compare
5aa7a30
to
3f63c70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this PR is not meant to completely align the fields with the new design as there are several things missing or different (e.g. tooltips, invalid error state icon, search clear button).
Not sure if you're continuing this work into Q4, but if you are, I suggest creating stories that replicate 1:1 the Figma designs. Easier to review and to confirm that the client implementation follows the mockups.
The goal was to simplify the components (remove no longer needed things) and to keep them flexible enough to support the new designs (which they do, unless I missed something) from the consumer side.
AFAIK, this work will be in the back burner for Q4, and might get picked up some time next year. |
Short description
This PR implements a few changes to adapt some of the form fields to the new form fields spec. Please refer to
CHANGELOG.md
(or the commit messages) to better understand the changes that were applied.Tip
Given the number of changes to bring the form field components to parity with the new form fields spec, a commit-by-commit review is recommended.
Warning
Don't be scared by the number of changes, most of them come from the last commit, which is a temporary commit that includes a Reactist build in this PR branch, so that I can pre-emptively open a PR on
ui-extensions
andtodoist-web
without having it break our CI checks.Before merging this PR, I'll remove that commit, and update both
ui-extensions
andtodoist-web
with the real package of Reactist v26.PR Checklist
npm run validate
and made sure no errors / warnings were shownCHANGELOG.md
package.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refVersioning
Breaking change, some props were removed from the
BaseField
component.