Dong/csv 4 #24
Annotations
10 errors and 11 warnings
golangci-lint:
light/client.go#L533
ineffectual assignment to l (ineffassign)
|
golangci-lint:
light/detector.go#L118
SA4006: this value of `lightBlock` is never used (staticcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L39
Error return value of `os.MkdirAll` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L173
Error return value of `m.CSVP2P` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L177
Error return value of `m.CSVEachHeight` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L178
Error return value of `m.CSVProposalStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L179
Error return value of `m.CSVTimeStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L180
Error return value of `m.CSVVoteStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L181
Error return value of `m.CSVRoundVoteSet` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L441
unnecessary conversion (unconvert)
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, technote-space/get-diff-action@v6, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
golangci-lint:
consensus/metrics_with_long_block.go#L100
var-naming: struct field roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L110
var-naming: struct field roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L120
var-naming: struct field roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L126
var-naming: struct field roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L141
var-naming: struct field roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L561
var-naming: method parameter roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L596
var-naming: method parameter roundId should be roundID (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L491
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L504
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L514
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|