Dong/csv 4 #30
Annotations
10 errors and 11 warnings
golangci-lint:
light/client.go#L533
ineffectual assignment to l (ineffassign)
|
golangci-lint:
light/detector.go#L118
SA4006: this value of `lightBlock` is never used (staticcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L39
Error return value of `os.MkdirAll` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L174
Error return value of `m.CSVP2P` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L179
Error return value of `m.CSVEachHeight` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L180
Error return value of `m.CSVProposalStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L181
Error return value of `m.CSVTimeStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L182
Error return value of `m.CSVVoteStep` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L183
Error return value of `m.CSVRoundVoteSet` is not checked (errcheck)
|
golangci-lint:
consensus/metrics_with_long_block.go#L450
unnecessary conversion (unconvert)
|
golangci-lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, technote-space/get-diff-action@v6, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
golangci-lint:
consensus/state.go#L529
increment-decrement: should replace metricTimeOut.metricsCache.eachHeight.numRound += 1 with metricTimeOut.metricsCache.eachHeight.numRound++ (revive)
|
golangci-lint:
consensus/state.go#L865
increment-decrement: should replace metricTimeOut.metricsCache.blockPartsSendTemporary += 1 with metricTimeOut.metricsCache.blockPartsSendTemporary++ (revive)
|
golangci-lint:
consensus/state.go#L867
increment-decrement: should replace metricTimeOut.metricsCache.blockPartsReceivedTemporary += 1 with metricTimeOut.metricsCache.blockPartsReceivedTemporary++ (revive)
|
golangci-lint:
consensus/state.go#L893
increment-decrement: should replace metricTimeOut.metricsCache.numVoteSentTemporary += 1 with metricTimeOut.metricsCache.numVoteSentTemporary++ (revive)
|
golangci-lint:
consensus/state.go#L895
increment-decrement: should replace metricTimeOut.metricsCache.numVoteReceivedTemporary += 1 with metricTimeOut.metricsCache.numVoteReceivedTemporary++ (revive)
|
golangci-lint:
consensus/state.go#L1185
increment-decrement: should replace metricTimeOut.metricsCache.eachHeight.proposalCreateCount += 1 with metricTimeOut.metricsCache.eachHeight.proposalCreateCount++ (revive)
|
golangci-lint:
consensus/state.go#L1376
increment-decrement: should replace metricTimeOut.metricsCache.eachHeight.proposalReceiveCount += 1 with metricTimeOut.metricsCache.eachHeight.proposalReceiveCount++ (revive)
|
golangci-lint:
consensus/state.go#L2032
increment-decrement: should replace metricTimeOut.metricsCache.eachHeight.blockGossipPartsReceived += 1 with metricTimeOut.metricsCache.eachHeight.blockGossipPartsReceived++ (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L504
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
golangci-lint:
consensus/metrics_with_long_block.go#L517
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|