Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety: Duplicate key SAFETY_VERSION #16

Closed
ioggstream opened this issue Nov 14, 2023 · 0 comments · Fixed by #26
Closed

safety: Duplicate key SAFETY_VERSION #16

ioggstream opened this issue Nov 14, 2023 · 0 comments · Fixed by #26
Assignees
@DrPlumcake
Labels
needs-triage we need to investigate this
Milestone
v1.0

Comments

@ioggstream
Copy link

I Expect

  • no duplicate keys in dict

Instead

        "SAFETY_VERSION": data["safety_version"] or data["telemetry"]["safety_version"],

See #15

Notes

Which is the precedence, e.g.
ioggstream added a commit to par-tec/super-sast-artifact that referenced this issue Nov 14, 2023
@ioggstream
Fix DrPlumcake#15, DrPlumcake#16. No duplicate safety version. Pre-co…
61511d9 
…mmit.
@ioggstream ioggstream mentioned this issue Nov 14, 2023
Merged
DrPlumcake added a commit that referenced this issue Nov 15, 2023
@DrPlumcake
Merge pull request #17 from par-tec/ioggstream-15
7da807a 
Fix: #15, #16. Deduplicate SAFETY_VERSION
@DrPlumcake DrPlumcake added this to the v1.0 milestone Nov 17, 2023
@DrPlumcake DrPlumcake self-assigned this Nov 17, 2023
@DrPlumcake DrPlumcake added bug Something isn't working needs-triage we need to investigate this and removed bug Something isn't working labels Nov 17, 2023
@DrPlumcake DrPlumcake mentioned this issue Nov 17, 2023
Merged
DrPlumcake added a commit that referenced this issue Nov 17, 2023
@DrPlumcake
Merge pull request #26 from DrPlumcake/drplum-16
af92c5e 
#16: De-duplicate Safety version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrPlumcake DrPlumcake

Labels
needs-triage we need to investigate this
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

#16: De-duplicate Safety version DrPlumcake/super-sast-action
2 participants
@ioggstream @DrPlumcake