Skip to content
This repository has been archived by the owner on Apr 26, 2020. It is now read-only.

#377 #386

Merged
merged 2 commits into from
Aug 22, 2019
Merged

#377 #386

merged 2 commits into from
Aug 22, 2019

Conversation

jamshidrostami
Copy link
Contributor

Added Arrow number to exported file

Added Arrow number to exported file
Copy link
Owner

@DreierF DreierF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙂
One minor comment.

csv.enterScope()
// Score
csv.add(target.zoneToString(scoringRing, index))

csv.add(if (arrowNumber == null) "" else arrowNumber)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the more compact ?: instead

arrowNumber ?: ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was changed

Simplify code
@DreierF DreierF merged commit 7c5ccc0 into DreierF:master Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants