Added support for skip_analytics config option. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSandeen
reviewed
Mar 9, 2022
BenSandeen
approved these changes
Mar 9, 2022
timbreitkreutz
approved these changes
Mar 9, 2022
stevedrip
approved these changes
Mar 9, 2022
will-in-wi
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Drip support recomended I try adding the "Skip-Analytics" header because our customers are getting the "Endpoint request timed out" error with our integration. This error is also mentioned in #54 which still throws an unproperly handled error.
Modification
Added configuration option
skip_analyticsthat you can pass into the client initializer.Result
According to support and my testing it'll skip adding count related metadata.