feat - add haptic feedback #1126
Conversation
|
Hi @Nanamare! Codes seem to be unformatted. To resolve this issue, please run |
|
As you can see, there is a person who raises a hand in the issue first. So if the person doesn't make a PR, I will merge this PR 🙇 |
| onBookmarkClick = { timetableItem, isBookmarked -> | ||
| haptic.performHapticFeedback( | ||
| HapticFeedbackType( | ||
| HapticFeedbackConstants.LONG_PRESS, |
There was a problem hiding this comment.
May I ask why you used LONG_PRESS here? 🙋
There was a problem hiding this comment.
@takahirom
it was supported starting from API Level 3, and the user experience and strength of haptic feedback were general! and It looks like it's long because it written Long_PRESS, but it's often used for general touch as well.
Do you have any better ideas ?!
There was a problem hiding this comment.
I'm just not familiar with this API and I was just wondering because this click is not a long press. Is there any API we can use for this? 👀
There was a problem hiding this comment.
How about VIRTUAL_KEY or KEYBOARD_TAP ?!
There was a problem hiding this comment.
@kosenda @fumiya-kume
May I ask your opinion on this?
There was a problem hiding this comment.
Personally, I think LONG_PRESS is fine.
Also, this may be off topic, but I thought Haptics was unnecessary when removing bookmarks.
There was a problem hiding this comment.
Oh, that's a good idea.
4330d47
github-actions
bot
temporarily deployed
to
deploygate-distribution
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)