Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timetable Feature: Fix an action of tapped favorite button #617

Closed
MrSmart00 opened this issue Aug 18, 2024 · 2 comments · Fixed by #657
Closed

Timetable Feature: Fix an action of tapped favorite button #617

MrSmart00 opened this issue Aug 18, 2024 · 2 comments · Fixed by #657

Comments

@MrSmart00
Copy link
Contributor

Overview

Currently, timetable cell's favorite button tapped action isn't correct.

Goal

  • change action when tapped favorite button action to switching heart icon.

Movie

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-18.at.20.53.01.mp4
@charles-b-stb
Copy link
Contributor

charles-b-stb commented Aug 19, 2024

@MrSmart00
I am looking into this and am unable to reproduce this strange animation.

The white snackbar looking thing is showing at the bottom though. That is new and is definitely not my code.

Was this added to the spec or is this something else? Its behind the tab bar and so its not visible.

@charles-b-stb charles-b-stb self-assigned this Aug 19, 2024
@charles-b-stb
Copy link
Contributor

@MrSmart00 @takahirom @shin-usu
Checking back on figma, there does not seem to be an account of the bookmark toast on this particular page (only on other pages). Maybe we don't need the bookmark toast on Timetable list view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants