Removed problematic toast (was not specified in Figma for this view) #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably, you can remove toast value from state. |
|
@shin-usu Fixed as suggested. Thanks! |
|
It seems like build error is occurring 👀 |
|
@shin-usu Sorry about that. This should fix that build issue. Tested again locally and it seems to be fine. |
shin-usu
reviewed
Aug 20, 2024
There was a problem hiding this comment.
@charles-b-stb
Thank you for your commit!
I left some comments. Please check and response🙏🏻
| @@ -103,7 +103,7 @@ public struct TimetableReducer : Sendable{ | |||
| return item.isFavorited | |||
| })) | |||
| } | |||
| case let .favoriteResponse(.success(isFavorited)): | |||
| case .favoriteResponse(.success(_)): | |||
There was a problem hiding this comment.
If isFavorited is unnecessary, favoriteResponse case's type should be modified.
For example.
public enum Action : Sendable, BindableAction {
...
case favoriteResponse(Result<Void, any Error>)
...
}
switch action {
...
case .favoriteResponse(.success):
return .none
...
}| state.toast = .init(text: String(localized: "AddFavorite", bundle: .module)) | ||
| } | ||
| case .favoriteResponse(.success(_)): | ||
| //No response here on purpose. Toasts look bad here. |
There was a problem hiding this comment.
I think this comment is unnecessary since toast does not exist in Reducer and View anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)