[iOS] refactor AboutView: improve button tap area & fix spacing & commonalize style #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze style 1. include the padding areas, expanding the tap area to the full width. 2. fix spacing（Because VStack has default spacing, need to set spacing: 0） 3. commonalize spacing and ButtonStyle and minor fixes(add opacity animation, add ButtonStyle & LabelStyle extension, remove unnecessary frame settings, etc)
I fixed this problem in #1029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)
include the padding areas, expanding the tap area to the full width.
fix spacing（Because VStack has default spacing, need to set spacing: 0）
commonalize spacing and ButtonStyle
and minor fixes(add opacity animation, add ButtonStyle & LabelStyle extension, remove unnecessary frame settings, etc)
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie
Other comment
I enabled the "Button Shapes" for testing purposes and confirmed that it causes the design to break.
If there is no existing issue for this, it might be a good idea to create one.