Add SwiftLint with default settings #149
Conversation
| workflow_run: | ||
| workflows: ["PR Labeler"] |
There was a problem hiding this comment.
I planned This workflow to run with PR Labeler workflow's completion.
but I can't check the workflow's actions. maybe it need to change a default branch i think. it's a troublesome so
If it don't working i'll fix if on the other PR👍
There was a problem hiding this comment.
Trigger by workflow is an interesting idea!
It might be nice and simple to use the fact that an iOS label has been assigned as a triggering event.
I think that would eliminate the need to fill in the if statement in the job.
https://docs.github.com/ja/actions/using-workflows/events-that-trigger-workflows#label
There was a problem hiding this comment.
Oh, Sorry.
I noticed that we can't specify the name of the label in the "on" part...
After all, the if statement had to be stated 🙇🏽♂️
app-ios/.swiftlint.yml
Outdated
There was a problem hiding this comment.
It's a demo configs from SwiftLint site.
| workflow_run: | ||
| workflows: ["PR Labeler"] |
There was a problem hiding this comment.
Trigger by workflow is an interesting idea!
It might be nice and simple to use the fact that an iOS label has been assigned as a triggering event.
I think that would eliminate the need to fill in the if statement in the job.
https://docs.github.com/ja/actions/using-workflows/events-that-trigger-workflows#label
.github/workflows/swiftlint.yml
Outdated
| runs-on: ubuntu-latest | ||
| if: contains(github.event.pull_request.labels.*.name, 'iOS 🍎') | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Latest checkout action is v4.
Do you have any reason to use v3? 😲
There was a problem hiding this comment.
Thanks👍 I fixed it!
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)