Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to open sheet when tapping contributor button in ContributorView #531

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

shin-usu
Copy link
Contributor

@shin-usu shin-usu commented Aug 16, 2024

Issue

Overview (Required)

  • Added logic to open sheet when tapping contributor button in ContributorView

Links

Movie (Optional)

Before After
2024-08-21.1.26.34.mov

@charles-b-stb
Copy link
Contributor

@shin-usu Could you add some screenshots (or a short video?) showing the before and after?

@shin-usu
Copy link
Contributor Author

@charles-b-stb
As I told you in Slack, this PR is blocked by an issue and I cannot confirm that it works.
Also, this PR is a draft and does not need to be reviewed yet.

@shin-usu shin-usu force-pushed the feature/ios_compose_view_contributor_tapped branch from 8296c6e to a0a4731 Compare August 20, 2024 16:27
@shin-usu shin-usu marked this pull request as ready for review August 20, 2024 16:28
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ry-itto ry-itto merged commit fc48e34 into main Aug 21, 2024
6 checks passed
@ry-itto ry-itto deleted the feature/ios_compose_view_contributor_tapped branch August 21, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Contributor sheet doesn't launch in KMP Compose Multiplatform
3 participants