Feature/446 gridlines #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for some reason (wip)
…gi/conference-app-2024 into feature/446-gridlines
…vertical grid lines yet.
…ng but if someone can get vertical grid lines working I would appreciate it.
|
Let's try just adding horizontal graph lines for now. If anyone can think of a reasonable way to add vertical lines I would appreciate it. 🙇 |
… feature/446-gridlines
MrSmart00
reviewed
Aug 21, 2024
| } else { | ||
| shape.frame(width: 1).padding(0) | ||
| } | ||
| //shape |
| } | ||
|
|
||
| struct LineShape: Shape { | ||
| public var axis: Axis |
There was a problem hiding this comment.
this property is 'let' more than better👍
| @@ -192,6 +194,39 @@ struct TimeGroupMiniList: View { | |||
| } | |||
| } | |||
|
|
|||
| struct DashedDivider: View { | |||
| public var axis: Axis | |||
There was a problem hiding this comment.
this property is 'let' more than better👍
There was a problem hiding this comment.
you should change here too🙏
|
@MrSmart00 Responded to comments, thanks! |
|
@MrSmart00 Sorry I missed that last time (it looked too similar to the other item I corrected and I did not notice they were separate the first time I looked at it.) Fixed now. |
MrSmart00
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Draft: The vertical lines are not yet working and I am looking for advice.
Branched off of the Grid UI pull request so that will need to be merged first.
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)