Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (at)retroactive to the extension to address the Xcode 16 warning. #568

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Add (at)retroactive to the extension to address the Xcode 16 warning. #568

merged 1 commit into from
Aug 17, 2024

Conversation

yimajo
Copy link
Contributor

@yimajo yimajo commented Aug 17, 2024

Issue

  • nothing

Overview (Required)

  • Due to SE-0364, protocol compliance of external modules will be subject to warnings unless the @retroactive attribute is declared.
  • Xcode 16 shows SE-0364 warning even on Swift 5.10. Use the hasFeature() macro for conditional compilation.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

MrSmart00
MrSmart00 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learn a lot from this PR Thank you!

@MrSmart00 MrSmart00 merged commit a6f1fbf into DroidKaigi:main Aug 17, 2024
4 checks passed
@yimajo yimajo deleted the add_attribute_retroactive branch August 19, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSmart00 MrSmart00 MrSmart00 approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yimajo @MrSmart00