Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension for SwiftGen code to conform to unchecked Sendable #630

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add extension for SwiftGen code to conform to unchecked Sendable #630

merged 2 commits into from
Aug 19, 2024

Conversation

yimajo
Copy link
Contributor

@yimajo yimajo commented Aug 18, 2024

Issue

Overview (Required)

  • Added an extension to make SwiftGen-generated types conform to unchecked Sendable
    • Why didn't this PR customize the stencil?
      • Because it had lazy var color: Color and it seemed like I had to make stencil @unchecked Sendable after all.
      • Additionally, since the class involved are Color or Font, the likelihood of data races in normal usage scenarios is minimal.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

ry-itto
ry-itto approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you!

@ry-itto ry-itto merged commit ca968b2 into DroidKaigi:main Aug 19, 2024
4 checks passed
@yimajo yimajo deleted the add_swiftgen_extension branch August 19, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yimajo @ry-itto