Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added margin to timetable grid view #618 #641

Merged
merged 1 commit into from
Aug 20, 2024
Merged

added margin to timetable grid view #618 #641

merged 1 commit into from
Aug 20, 2024

Conversation

shunsugawara
Copy link
Contributor

Issue

Overview (Required)

  • Added 16 end paddings to gridView.
  • The bottom padding was specified as 16. However I have changed it to 60(including the height of the bottom tab), to match the case of the List View. Therefore, we have added 68(60 + default spacing 8).

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

charles-b-stb
charles-b-stb approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@charles-b-stb charles-b-stb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@shin-usu shin-usu merged commit a0a5cc0 into DroidKaigi:main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-b-stb charles-b-stb charles-b-stb approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timetable Feature: Add margin around Timetable Grid display
3 participants
@shunsugawara @charles-b-stb @shin-usu