Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English translation support for About Screen Title & Search Chips #644

Merged

Conversation

fumiyasac
Copy link
Contributor

@fumiyasac fumiyasac commented Aug 19, 2024

Issue

Overview

Modify Localizable.xcstrings below:

  • modify AboutFeature/Localizable.xcstrings (NavigationTitle)
  • modify SearchFeature/Resources/Localizable.xcstrings (SearchChip)

(If you notice anything else I've overlooked, I'd appreciate it if you could leave a comment 🙏 )

Screenshot (Optional if screenshot test is present or unrelated to UI)

About Screen Search Chips

@shin-usu
Copy link
Contributor

@fumiyasac
Thank you for your commit!!
Currently, some strings have been put in temporarily in AboutView. (e.g KeyVisualDateKey, KeyVisualDateValue, etc...)
Could you please replace this strings?

@fumiyasac
Copy link
Contributor Author

@shin-usu Oh, sorry ...
I applied the necessary translations to the About screen by referring to the settings on the Android side. 39d74f5
※ Screen Capture about About Scene replaced !

Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM😊🎉

@shin-usu shin-usu merged commit 7cf9351 into DroidKaigi:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants