Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Add suffix actual method file #676

Merged
merged 13 commits into from
Aug 21, 2024
Merged

📝 Add suffix actual method file #676

merged 13 commits into from
Aug 21, 2024

Conversation

Corvus400
Copy link
Contributor

Issue

Overview (Required)

  • Added ios and android suffixes to all actual files to follow the descriptions in the official documentation listed in the Issue.

Links

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 05:54 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 06:46 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 07:13 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 08:00 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 08:14 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review August 20, 2024 08:23
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 21, 2024 05:33 Inactive
@takahirom takahirom self-requested a review August 21, 2024 13:47
takahirom
takahirom approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for maintaining our consistency.

@takahirom takahirom merged commit 98e8a3f into DroidKaigi:main Aug 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The expect/actual method file must have each platform suffix (ex. .ios .android .jvm) before the .kt.
2 participants
@Corvus400 @takahirom