Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS KMP resources #685

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

takahirom
Copy link
Member

@takahirom takahirom commented Aug 20, 2024

Issue

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@takahirom takahirom force-pushed the takahirom/fix-ios-kmp-resource2/2024-08-20 branch from 8a69abe to 21956b9 Compare August 20, 2024 15:23
@@ -173,7 +177,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/zsh;
shellScript = "cd ${SRCROOT}/../..\n./gradlew assembleSharedXCFramework --no-configuration-cache\n";
shellScript = "cd ${SRCROOT}/../..\n./gradlew assembleSharedXCFramework --no-configuration-cache\n./gradlew iosSimulatorArm64AggregateResources --no-configuration-cache\n\nRESOURCE_DIR=\"./app-ios-shared/build/kotlin-multiplatform-resources/aggregated-resources/iosSimulatorArm64\"\n\nmkdir ${RESOURCE_DIR}/compose-resources\ncp -R ${RESOURCE_DIR}/composeResources ${RESOURCE_DIR}/compose-resources\n";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is this

cd ${SRCROOT}/../..
./gradlew assembleSharedXCFramework --no-configuration-cache
./gradlew iosSimulatorArm64AggregateResources --no-configuration-cache

RESOURCE_DIR="./app-ios-shared/build/kotlin-multiplatform-resources/aggregated-resources/iosSimulatorArm64"

mkdir ${RESOURCE_DIR}/compose-resources
cp -R ${RESOURCE_DIR}/composeResources ${RESOURCE_DIR}/compose-resources

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 20, 2024 15:27 Inactive
Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@shin-usu shin-usu merged commit 093b3fd into main Aug 20, 2024
8 checks passed
@shin-usu shin-usu deleted the takahirom/fix-ios-kmp-resource2/2024-08-20 branch August 20, 2024 15:40
@takahirom takahirom added the awesome Label for project-applicable insights or remarkable technologies. label Aug 20, 2024
@@ -15,6 +16,7 @@
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
830BFA7B2C74EBF40017A600 /* compose-resources */ = {isa = PBXFileReference; lastKnownFileType = folder; name = "compose-resources"; path = "../../app-ios-shared/build/kotlin-multiplatform-resources/aggregated-resources/iosSimulatorArm64/compose-resources"; sourceTree = "<group>"; };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awesome Label for project-applicable insights or remarkable technologies. type:iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when KMP Presenter or KMP Compose View is selected on the ContributorView.
2 participants