Enable to view conference day tab even if font size is large #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ked4ma
commented
Aug 22, 2024
| // calculate width from sp | ||
| // NOTE: 6 is a magic number here | ||
| ((16.sp * 6) * fontScale).toDp() | ||
| } |
There was a problem hiding this comment.
TabRow try to use max width as much as possible, so we need to specify fixed width.
For this, calculating the width (dp) from sp using density.
ked4ma
commented
Aug 22, 2024
| text = text, | ||
| fontWeight = FontWeight.W400, | ||
| style = MaterialTheme.typography.titleMedium, |
There was a problem hiding this comment.
attached font that is used for text components.
takahirom
approved these changes
Aug 23, 2024
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-13 - it should show timetable items for ConferenceDay2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-13%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay2%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-12 - switch to grid timetable - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-12%20-%20switch%20to%20grid%20timetable%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - it should change timetable ui type]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20it%20should%20change%20timetable%20ui%20type%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-12 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-12%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current datetime is 2024-09-12 10-30 - it should show an indicator of the current time at 10-30]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20datetime%20is%202024-09-12%2010-30%20-%20it%20should%20show%20an%20indicator%20of%20the%20current%20time%20at%2010-30%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when device is tablet - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20device%20is%20tablet%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is down - it should show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20down%20-%20it%20should%20show%20error%20message%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click conference day2 tab - it should change displayed day]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20conference%20day2%20tab%20-%20it%20should%20change%20displayed%20day%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-11 - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-11%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - scroll timetable - it should first session is not displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20scroll%20timetable%20-%20it%20should%20first%20session%20is%20not%20displayed%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - click conference day2 tab - it should change displayed day]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20click%20conference%20day2%20tab%20-%20it%20should%20change%20displayed%20day%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current datetime is 2024-09-11 10-00 - it should not show an indicator of the current time]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20datetime%20is%202024-09-11%2010-00%20-%20it%20should%20not%20show%20an%20indicator%20of%20the%20current%20time%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-11 - switch to grid timetable - it should show timetable items for ConferenceDay1]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-11%20-%20switch%20to%20grid%20timetable%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay1%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - scroll timetable - it should first session is not displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20scroll%20timetable%20-%20it%20should%20first%20session%20is%20not%20displayed%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current datetime is 2024-09-13 11-00 - it should show an indicator of the current time at 11-00]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20datetime%20is%202024-09-13%2011-00%20-%20it%20should%20show%20an%20indicator%20of%20the%20current%20time%20at%2011-00%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click first session bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20first%20session%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when the current date is 2024-09-13 - switch to grid timetable - it should show timetable items for ConferenceDay2]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20the%20current%20date%20is%202024-09-13%20-%20switch%20to%20grid%20timetable%20-%20it%20should%20show%20timetable%20items%20for%20ConferenceDay2%5D_compare.png){kind=link}
![KaigiAppTest[KaigiApp - when app is starting - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/timetable-day-tab-size/./screenshot-diff-reports/app-android/build/outputs/roborazzi/KaigiAppTest%5BKaigiApp%20-%20when%20app%20is%20starting%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)