-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failed test #797
base: main
Are you sure you want to change the base?
fix failed test #797
Conversation
Detekt check failed. Please run |
I don't think we have a CI set up for running this test, which means it could break at any time. Could you add it? I think running just one task is enough. |
.github/workflows/unit-test.yml
Outdated
- run: | | ||
./gradlew \ | ||
:core:data:iosSimulatorArm64Test \ | ||
:core:model:iosSimulatorArm64Test \ | ||
--stacktrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for delay. 🙇
There were another module for which iOS tests were not being run, so I specified them.
I am not similar with Gradle syntax, but is this acceptable?
.github/workflows/unit-test.yml
Outdated
- run: | | ||
./gradlew \ | ||
:core:data:iosSimulatorArm64Test \ | ||
:core:model:iosSimulatorArm64Test \ | ||
--stacktrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The iosSimulatorArm64Test
might be skipped on ubuntu-latest
. Could we change ubuntu-latest
to macos-latest
?
Additionally, we might need to modify the screenshot-comparison
workflow to use macos-latest
so that we have the same environment for the screenshots. I think we could merge the existing tests to speed up the process.
- run: ./gradlew \
testDevDebugUnitTest \
testDebugUnitTest \
:core:data:iosSimulatorArm64Test \
:core:model:iosSimulatorArm64Test \
--stacktrace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, CI failed 🙇
I will try to fix
Issue
Overview (Required)
Acceptance conditions
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)