Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Run SwiftLint properly #889

Merged
merged 1 commit into from
Aug 31, 2024
Merged

[iOS] Run SwiftLint properly #889

merged 1 commit into from
Aug 31, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Aug 30, 2024

Issue

  • close N/A

Overview (Required)

  • This PR fixes invalid included paths in the configuration to run SwiftLint properly:
Error: No lintable files found at paths: ''

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

shin-usu
shin-usu approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks🙏

@shin-usu shin-usu merged commit e262833 into DroidKaigi:main Aug 31, 2024
3 checks passed
@woxtu woxtu deleted the included-paths branch August 31, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shin-usu shin-usu shin-usu approved these changes

Assignees
No one assigned
Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @shin-usu