♻️ Since the About screen test has not been implemented, it has been implemented except where the Issue manager is located. #908
+101
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented except where the Issue manager is located. DroidKaigi#670
Corvus400
commented
Sep 1, 2024
Comment on lines
+44
to
+46
| composeTestRule.onRoot().performTouchInput { | ||
| swipeUp(startY = centerY, endY = centerY - 200) | ||
| } |
There was a problem hiding this comment.
If you don't scroll slightly, performScrollToNode won't scroll to the right place.
Since it has already been pointed out that scrolling using the index is not very good, we are manually shifting the position to deal with it.
#887 (comment)
There was a problem hiding this comment.
Thanks. Could we have a FIXME comment for this like Without this we can't scroll to the creditsSection or something
There was a problem hiding this comment.
@takahirom
The sentence is a little different, but I added it. 🫡
Corvus400
commented
Sep 1, 2024
| @@ -92,7 +93,7 @@ fun LazyListScope.aboutOthers( | |||
| leadingIcon = Outlined.Settings, | |||
| label = stringResource(AboutRes.string.settings), | |||
| onClickAction = onSettingsItemClick, | |||
| testTag = "TODO", | |||
| testTag = AboutOthersSettingsItemTestTag, | |||
There was a problem hiding this comment.
This was left as a TODO, so I went to check the test and added it because it had not been implemented at all.
![AboutScreenTest[AboutScreen - when launch - when scroll to credits section - it should show credits contents]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/implement_basic_test_for_about_screen/./screenshot-diff-reports/feature/about/build/outputs/roborazzi/AboutScreenTest%5BAboutScreen%20-%20when%20launch%20-%20when%20scroll%20to%20credits%20section%20-%20it%20should%20show%20credits%20contents%5D_compare.png){kind=link}
![AboutScreenTest[AboutScreen - when launch - when scroll to others section - it should show others contents]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/implement_basic_test_for_about_screen/./screenshot-diff-reports/feature/about/build/outputs/roborazzi/AboutScreenTest%5BAboutScreen%20-%20when%20launch%20-%20when%20scroll%20to%20others%20section%20-%20it%20should%20show%20others%20contents%5D_compare.png){kind=link}
takahirom
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links