-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add animation when you tap heartmark in timetable list. #944
[iOS] Add animation when you tap heartmark in timetable list. #944
Conversation
} | ||
Task { | ||
try await Task.sleep(nanoseconds: 1_000_000_000) | ||
targetTimetableItemId = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this warning? 🙏🏼
capture of 'self' with non-sendable type 'TimetableListView' in a
@Sendable
closure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ry-itto I think you can solve it like this.
@MainActor
struct TimetableListView: View { ... }
@ry-itto I fixed warning. Please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
Overview
TimetableCard.swift
onTapFavorite: (TimetableItem, CGPoint?) -> Void
.TimetableListView.swift
Points that seem difficult to achieve:
Note
This is an experimental creation, so feel free to discard it if it doesn't meet your needs 🙇
Movie
Portrait:
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-01.at.21.04.23.mp4
Landscape:
tap_heartmark_in_landscape.mov