[iOS] Add sendable conformance to event map feature #965
+86
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry-itto
reviewed
Sep 5, 2024
| public let name: MultiLangText | ||
| public let roomName: MultiLangText | ||
| public let roomIcon: RoomIcon | ||
| public let description_: MultiLangText |
There was a problem hiding this comment.
I think this _ isn't needed for iOS side code 👀
Suggested change
| public let description_: MultiLangText | |
| public let description: MultiLangText |
MrSmart00
reviewed
Sep 5, 2024
| @@ -2,9 +2,10 @@ import SwiftUI | |||
| import CommonComponents | |||
| import Theme | |||
| import shared | |||
There was a problem hiding this comment.
Can you remove this import with your modified?
I guess Model package wrapped shared package, it makes shared imports to be no needed.
| @@ -2,7 +2,7 @@ import ComposableArchitecture | |||
| import KMPClient | |||
| import Model | |||
| import Foundation | |||
| @preconcurrency import shared | |||
| import shared | |||
There was a problem hiding this comment.
Can you remove this import with your modified?
I guess Model package wrapped shared package, it makes shared imports to be no needed.
MrSmart00
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)