[ProfileCardScreen] Design enhancement #971
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
reviewed
Sep 5, 2024
| @@ -260,6 +260,7 @@ private fun NavGraphBuilder.mainScreen( | |||
| profileCardScreen( | |||
| contentPadding = contentPadding, | |||
| onClickShareProfileCard = externalNavController::onShareProfileCardClick, | |||
| onNavigationBackIconClick = mainNestedNavController::navigateUp, | |||
There was a problem hiding this comment.
Thank you for your pull request! I think we need to change IosComposeKaigiApp as well 🙏
There was a problem hiding this comment.
Thanks for the prompt review.
Seems like IosComposeKaigiApp and unitTest needs to be sync with the added code.
I will fix and resubmit the code asap.
![ProfileCardScreenTest[ProfileCardScreen - when profile card is exists - when click edit button - it should show edit screen]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20exists%20-%20when%20click%20edit%20button%20-%20it%20should%20show%20edit%20screen%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - when url contains sub domain - it should not show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20when%20url%20contains%20sub%20domain%20-%20it%20should%20not%20show%20error%20message%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - when url top level domain is missing - it should show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20when%20url%20top%20level%20domain%20is%20missing%20-%20it%20should%20show%20error%20message%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is exists - when click edit button - if all required fields are filled in - it should make sure the Create button is activated]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20exists%20-%20when%20click%20edit%20button%20-%20if%20all%20required%20fields%20are%20filled%20in%20-%20it%20should%20make%20sure%20the%20Create%20button%20is%20activated%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - when url contains IDN domain name - it should not show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20when%20url%20contains%20IDN%20domain%20name%20-%20it%20should%20not%20show%20error%20message%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is exists - when click edit button - when if a required field has not been filled in - it should make sure the Create button is deactivated]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20exists%20-%20when%20click%20edit%20button%20-%20when%20if%20a%20required%20field%20has%20not%20been%20filled%20in%20-%20it%20should%20make%20sure%20the%20Create%20button%20is%20deactivated%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - when protocol is missing - it should not show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20when%20protocol%20is%20missing%20-%20it%20should%20not%20show%20error%20message%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - it should show edit screen]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20it%20should%20show%20edit%20screen%5D_compare.png){kind=link}
![ProfileCardScreenTest[ProfileCardScreen - when profile card is does not exists - when url protocol is invalid - it should show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/profile-edit-screen-design-enhancement/./screenshot-diff-reports/feature/profilecard/build/outputs/roborazzi/ProfileCardScreenTest%5BProfileCardScreen%20-%20when%20profile%20card%20is%20does%20not%20exists%20-%20when%20url%20protocol%20is%20invalid%20-%20it%20should%20show%20error%20message%5D_compare.png){kind=link}
|
Sorry, I forgot about this. We should implement back button |
masah517
force-pushed
the
feature/profile-edit-screen-design-enhancement
branch
from
aeb9e9d
to
82bcd5c
Compare
|
Hi @takahirom -san My apologies for accidentally closing the PR due to the force push, while resolving the conflict. Sorry for any problem occurred |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)