Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage of store.receive in multiple tests #975

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

yimajo
Copy link
Contributor

@yimajo yimajo commented Sep 5, 2024

Issue

Overview (Required)

  • To improve the accuracy and comprehensiveness of the tests.
    • Existing practices have not been tested for success or failure.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

Modify to correctly assert error reception
Modify to correctly assert error reception
Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shin-usu shin-usu merged commit 575b3f4 into DroidKaigi:main Sep 5, 2024
4 checks passed
@yimajo yimajo deleted the improve_test_receive_path branch September 6, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants