Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sponsor view bugs #977

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix sponsor view bugs #977

merged 3 commits into from
Sep 6, 2024

Conversation

shin-usu
Copy link
Contributor

@shin-usu shin-usu commented Sep 5, 2024

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Add logic to open sponsor page
  • Fix behavior when tapping sponsor button
    • Currently, when the button is tapped, a square background is displayed.

Movie (Optional)

open sponsor page

Before After
2024-09-06.0.49.00.mov

Fix behavior when tapping sponsor button

Before After
2024-09-06.0.19.11.mov
2024-09-06.0.25.21.mov

@shin-usu shin-usu marked this pull request as ready for review September 5, 2024 16:14
Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your commits!
LGTM 🙏

@shin-usu shin-usu merged commit 0148d94 into main Sep 6, 2024
5 checks passed
@shin-usu shin-usu deleted the feature/open-sponsor-page-ios branch September 6, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants