Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContributorsScreen] Display the total number of persons in ContributorsScreen #982

Merged

Conversation

raseln
Copy link
Contributor

@raseln raseln commented Sep 6, 2024

Issue

Overview (Required)

  • Implement animated total number of contributors UI in ContributorsScreen of Compose
  • Implement animated total number of contributors UI in ContributorsScreen of SwiftUI for both representation
  • Write Robo test of Compose UI item

Links

Movie (Optional)

BeforeAndroid AfterAndroid
BeforeAndroid.mp4
AfterAndroid.mp4
BeforeiOS AfteriOS
BeforeiOS.mov
AfteriOS.mov

@raseln raseln marked this pull request as ready for review September 6, 2024 06:20
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 6, 2024 14:49 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on iOS as well; it seems great.

Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS implementation looks good to me!

@takahirom takahirom merged commit bab8c00 into DroidKaigi:main Sep 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the total number of persons in ContributorsScreen
3 participants