Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make way-points non-select-able when a tool is selected in editor #952

Closed
zlite opened this issue Jul 30, 2014 · 7 comments
Closed

Make way-points non-select-able when a tool is selected in editor #952

zlite opened this issue Jul 30, 2014 · 7 comments

Comments

@zlite
Copy link
Contributor

zlite commented Jul 30, 2014

The current "touch ignored" zone around existing home/waypoints is too large, and it is difficult to place new waypoints near existing ones.

@squilter
Copy link
Member

I agree that it is too large. But I don't think there's an easy fix. Here's the relevant line of code from EditorMapFragment:
mMapFragment.setOnMarkerClickListener(this);

Nowhere in the GoogleMap API does it ask for a radius. I couldn't find anything in the docs either.

@arthurbenemann arthurbenemann changed the title Shrink "no touch zone" around existing waypoints to allow for easier new waypoint placement Make way-points non-drag-able when a tool is selected Jul 30, 2014
@arthurbenemann arthurbenemann changed the title Make way-points non-drag-able when a tool is selected Make way-points non-select-able when a tool is selected in editor Jul 30, 2014
@arthurbenemann
Copy link
Member

The solution here is to make the waypoints non-select-able when there is a tool selected on the editor window.

@arthurbenemann arthurbenemann added this to the Bug Free milestone Jul 30, 2014
@TShapinsky
Copy link
Member

After looking into it for a bit I don't believe there is any intuitive way to do this using the google maps api. Please prove me wrong.

edit: There is no method to make markers un-clickable. Clicking anywhere near the marker will not call the onMapClick() method, even if the onMarkerClick() is overridden.

@arthurbenemann
Copy link
Member

@squilter
Copy link
Member

@arthurbenemann But that will just put the new marker in the exact same place as the old marker, not a little bit to the side.

I think we need to write down all of the limitations that we are coming across with the maps api and ask google to implement them.

@arthurbenemann
Copy link
Member

@squilter It's better than what we have now. I agree that these should be reported to the google maps people, but they might take a long time to implement it.

@squilter
Copy link
Member

Here seems to be the right place to report it. We also need to report #1079 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants